Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Mesh.disconnect(points_per_cell=None, calc_points=True) #403

Merged
merged 2 commits into from
Mar 26, 2023

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Mar 26, 2023

This includes:

  • Make the re-evaluation of point coordinates optional
  • Specify (trim) the number of points per cell (for Taylor-Hood Displacement-Pressure element formulations)

...and the following code-block will be possible:

# create a hexahedron-region on a cube
region = fem.RegionTriQuadraticHexahedron(mesh)

# add a mixed field container (with displacement, pressure and volume ratio)
mesh_dual = mesh.disconnect(points_per_cell=8, calc_points=False)
field = fem.FieldsMixed(region, n=3, mesh=mesh_dual)

closes #402

@adtzlr adtzlr added the enhancement New feature or request label Mar 26, 2023
@adtzlr adtzlr added this to the 6.4 milestone Mar 26, 2023
@adtzlr adtzlr self-assigned this Mar 26, 2023
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (caff7f4) 97.41% compared to head (7585325) 97.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files          81       81           
  Lines        3633     3640    +7     
=======================================
+ Hits         3539     3546    +7     
  Misses         94       94           
Impacted Files Coverage Δ
src/felupe/mesh/_mesh.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adtzlr adtzlr merged commit 7f7d927 into main Mar 26, 2023
@adtzlr adtzlr deleted the enhance-mesh-disconnect branch March 26, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Mesh.disconnect()
1 participant