Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scalar-checks in mesh.expand() and mesh.revolve() #421

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Apr 3, 2023

for z and phi. They failed if they were of type np.int32. The check is changed and now uses np.isscalar().

fixes #420

@adtzlr adtzlr added the bug Something isn't working label Apr 3, 2023
@adtzlr adtzlr added this to the 7.0 milestone Apr 3, 2023
@adtzlr adtzlr self-assigned this Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d7085ec) 97.75% compared to head (5865233) 97.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #421   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          80       80           
  Lines        3660     3660           
=======================================
  Hits         3578     3578           
  Misses         82       82           
Impacted Files Coverage Δ
src/felupe/mesh/_tools.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adtzlr adtzlr merged commit 38ae800 into main Apr 3, 2023
@adtzlr adtzlr deleted the fix-mesh-expand-revolve-isscalar branch April 3, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scalar-value checks are failing in mesh.expand() and mesh.revolve()
1 participant