Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Mesh: Mesh tools as methods #425

Merged
merged 9 commits into from
Apr 5, 2023
Merged

Enhance Mesh: Mesh tools as methods #425

merged 9 commits into from
Apr 5, 2023

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Apr 5, 2023

A more object-oriented Mesh

  • rename old Mesh to DiscreteGeometry
  • create Mesh on top of DiscreteGeometry
  • add all mesh-related tools as methods to the new Mesh class

closes #424

This enables

import felupe as fem

fem.Rectangle(n=5).expand(n=4, z=1)

in addition to the still useful but sometimes very lengthy code

import felupe as fem

rect = fem.Rectangle(n=5)
cube = fem.mesh.expand(rect, n=4, z=1)

@adtzlr adtzlr added the enhancement New feature or request label Apr 5, 2023
@adtzlr adtzlr added this to the 7.0 milestone Apr 5, 2023
@adtzlr adtzlr self-assigned this Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (b526111) 97.76% compared to head (5053cc1) 97.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   97.76%   97.79%   +0.03%     
==========================================
  Files          80       81       +1     
  Lines        3663     3720      +57     
==========================================
+ Hits         3581     3638      +57     
  Misses         82       82              
Impacted Files Coverage Δ
src/felupe/mesh/_convert.py 96.39% <100.00%> (ø)
src/felupe/mesh/_discrete_geometry.py 100.00% <100.00%> (ø)
src/felupe/mesh/_helpers.py 100.00% <100.00%> (ø)
src/felupe/mesh/_mesh.py 100.00% <100.00%> (ø)
src/felupe/mesh/_tools.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adtzlr adtzlr merged commit 62a40fc into main Apr 5, 2023
@adtzlr adtzlr deleted the mesh-tools-as-methods branch April 5, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the usage of mesh-related tools
1 participant