Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Result() for plotting XDMF-files #456

Merged
merged 17 commits into from
Apr 22, 2023
Merged

Add Result() for plotting XDMF-files #456

merged 17 commits into from
Apr 22, 2023

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Apr 21, 2023

based on pyvista >= 0.39 (not released, can't be tested right now)

Tasks

  • add pyvista to optional requirements
  • test the new plotter

closes #454

result

@adtzlr adtzlr added the enhancement New feature or request label Apr 21, 2023
@adtzlr adtzlr added this to the 7.2 milestone Apr 21, 2023
@adtzlr adtzlr self-assigned this Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (5f51048) 98.12% compared to head (80bdd75) 98.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
+ Coverage   98.12%   98.15%   +0.03%     
==========================================
  Files          82       83       +1     
  Lines        3790     3856      +66     
==========================================
+ Hits         3719     3785      +66     
  Misses         71       71              
Impacted Files Coverage Δ
src/felupe/__init__.py 100.00% <100.00%> (ø)
src/felupe/tools/__init__.py 100.00% <100.00%> (ø)
src/felupe/tools/_plot.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adtzlr adtzlr changed the title Add ResultFile() for plotting XDMF-files Add Result() for plotting XDMF-files Apr 22, 2023
@adtzlr adtzlr merged commit be3ac35 into main Apr 22, 2023
@adtzlr adtzlr deleted the add-result-plotter branch April 22, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot XDMF with PyVista
1 participant