Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't modify a given label in Scene.plot(label=None) #495

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Jun 16, 2023

fixes #494

@adtzlr adtzlr added the bug Something isn't working label Jun 16, 2023
@adtzlr adtzlr added this to the 7.5 milestone Jun 16, 2023
@adtzlr adtzlr self-assigned this Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (bc6a16f) 97.87% compared to head (c057075) 97.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   97.87%   97.88%           
=======================================
  Files          84       84           
  Lines        3914     3920    +6     
=======================================
+ Hits         3831     3837    +6     
  Misses         83       83           
Impacted Files Coverage Δ
src/felupe/tools/_plot.py 97.93% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adtzlr adtzlr changed the title Scene.plot(label=None): Don't modify a given label. Don't modify a given label in Scene.plot(label=None) Jun 16, 2023
@adtzlr adtzlr merged commit ac11c77 into main Jun 16, 2023
@adtzlr adtzlr deleted the fix-scene-label branch June 16, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scene: Custom label is not directly passed to the plotter
1 participant