Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary kwargs in core constitutive materials #843

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Aug 31, 2024

Remove material parameter keyword-arguments in the function()-, gradient()- and hessian()-methods of the core constitutive material formulations. This removes the ability for temporary material parameters in LinearElastic(E=None, nu=0.3).gradient(x, E=1.0), use LinearElastic(E=1.0, nu=0.3).gradient(x) instead. This affects the material formulations LinearElastic, LinearElasticPlaneStrain, LinearElasticPlaneStress, LinearElasticLargeStrain, NeoHooke and NeoHookeCompressible.

closes #841

@adtzlr adtzlr added the enhancement New feature or request label Aug 31, 2024
@adtzlr adtzlr added this to the 9.0 milestone Aug 31, 2024
@adtzlr adtzlr self-assigned this Aug 31, 2024
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (6fe8d85) to head (07efcb6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #843      +/-   ##
==========================================
- Coverage   97.57%   97.54%   -0.03%     
==========================================
  Files         149      149              
  Lines        5766     5705      -61     
==========================================
- Hits         5626     5565      -61     
  Misses        140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adtzlr adtzlr merged commit 1886d20 into main Aug 31, 2024
6 checks passed
@adtzlr adtzlr deleted the remove-umat-temp-kwargs branch August 31, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify constitutive materials
1 participant