Mashup Homework #42
Open
Mashup Homework #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st Version. Needs lots of refactoring and styling too.
Refactored. Still needs more refactoring.
Refactored. Still needs more refactoring.
Styled and refactored for now.
| float: right; | ||
| cursor: pointer; | ||
| } | ||
| section[id*="news"] { |
There was a problem hiding this comment.
I'd recommend using a class for all of these, rather than partially matching an ID. Will make your page render more quickly.
There was a problem hiding this comment.
Not to mention being more conventional, when there isn't an advantage to going against it.
|
Love the app! In particular, you made a very good use of small, specific classes. Hope you had fun with it once you found a good API to use? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored and styled.