Make it so the aom:process command can have the visit and/or conversion batch size/limit be defined via ---visit-batch-size and/or --conversion-batch-size
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, the limits are just defaults that can be changed depending on the user's needs & the server's capabilities.
…rsion checking. Now, the user can tell the aom:process command how many items (visits/conversions) they want to be processed in that batch.
Code cleanup.
KZeni
changed the title
aom:process command can have the visit and/or conversion batch size/limit be defined via ---visit-batch-size and --conversion-batch-size
KZeni
changed the title
aom:process command can have the visit and/or conversion batch size/limit be defined via ---visit-batch-size and --conversion-batch-sizeaom:process command can have the visit and/or conversion batch size/limit be defined via ---visit-batch-size and/or --conversion-batch-size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the visit checking function processes 500 visits at a time and the conversion checking function processes 100 at a time. These two limits are hard-coded, currently. I have a larger Piwik installation and a capable server so I want to be able to define these two limits when I use aom:process.
This update adds the functionality to specify this via the aom:process command, and the functions have also been updated to account for the specified limits/batch size (with the previous hard-coded values simply used as the default).