Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ハイライトを隠す #19

Merged
merged 2 commits into from
Mar 25, 2024
Merged

ハイライトを隠す #19

merged 2 commits into from
Mar 25, 2024

Conversation

adzukimame
Copy link
Owner

@adzukimame adzukimame commented Mar 25, 2024

What

  • ハイライトのノートの取得(notes/featured)をクレデンシャル必須に
  • リモートの人気・最近投稿・最近発見ユーザーの取得をクレデンシャル必須に
  • 非ログイン時に"#みつける"内のタブを適宜隠す

Copy link

github-actions bot commented Mar 25, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -51365,10 +51365,10 @@
       }
     },
     "/notes/featured": {
-      "get": {
+      "post": {
         "operationId": "notes/featured",
         "summary": "notes/featured",
-        "description": "No description provided.\n\n**Credential required**: *No*",
+        "description": "No description provided.\n\n**Credential required**: *Yes* / **Permission**: *read:account*",
         "externalDocs": {
           "description": "Source code",
           "url": "https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/notes/featured.ts"
@@ -51376,167 +51376,10 @@
         "tags": [
           "notes"
         ],
-        "requestBody": {
-          "required": true,
-          "content": {
-            "application/json": {
-              "schema": {
-                "type": "object",
-                "properties": {
-                  "limit": {
-                    "type": "integer",
-                    "minimum": 1,
-                    "maximum": 100,
-                    "default": 10
-                  },
-                  "untilId": {
-                    "type": "string",
-                    "format": "misskey:id"
-                  },
-                  "channelId": {
-                    "type": [
-                      "string",
-                      "null"
-                    ],
-                    "format": "misskey:id"
-                  }
-                }
-              }
-            }
-          }
-        },
-        "responses": {
-          "200": {
-            "description": "OK (with results)",
-            "content": {
-              "application/json": {
-                "schema": {
-                  "type": "array",
-                  "items": {
-                    "type": "object",
-                    "$ref": "#/components/schemas/Note"
-                  }
-                }
-              }
-            }
-          },
-          "400": {
-            "description": "Client error",
-            "content": {
-              "application/json": {
-                "schema": {
-                  "$ref": "#/components/schemas/Error"
-                },
-                "examples": {
-                  "INVALID_PARAM": {
-                    "value": {
-                      "error": {
-                        "message": "Invalid param.",
-                        "code": "INVALID_PARAM",
-                        "id": "3d81ceae-475f-4600-b2a8-2bc116157532"
-                      }
-                    }
-                  }
-                }
-              }
-            }
-          },
-          "401": {
-            "description": "Authentication error",
-            "content": {
-              "application/json": {
-                "schema": {
-                  "$ref": "#/components/schemas/Error"
-                },
-                "examples": {
-                  "CREDENTIAL_REQUIRED": {
-                    "value": {
-                      "error": {
-                        "message": "Credential required.",
-                        "code": "CREDENTIAL_REQUIRED",
-                        "id": "1384574d-a912-4b81-8601-c7b1c4085df1"
-                      }
-                    }
-                  }
-                }
-              }
-            }
-          },
-          "403": {
-            "description": "Forbidden error",
-            "content": {
-              "application/json": {
-                "schema": {
-                  "$ref": "#/components/schemas/Error"
-                },
-                "examples": {
-                  "AUTHENTICATION_FAILED": {
-                    "value": {
-                      "error": {
-                        "message": "Authentication failed. Please ensure your token is correct.",
-                        "code": "AUTHENTICATION_FAILED",
-                        "id": "b0a7f5f8-dc2f-4171-b91f-de88ad238e14"
-                      }
-                    }
-                  }
-                }
-              }
-            }
-          },
-          "418": {
-            "description": "I'm Ai",
-            "content": {
-              "application/json": {
-                "schema": {
-                  "$ref": "#/components/schemas/Error"
-                },
-                "examples": {
-                  "I_AM_AI": {
-                    "value": {
-                      "error": {
-                        "message": "You sent a request to Ai-chan, Misskey's showgirl, instead of the server.",
-                        "code": "I_AM_AI",
-                        "id": "60c46cd1-f23a-46b1-bebe-5d2b73951a84"
-                      }
-                    }
-                  }
-                }
-              }
-            }
-          },
-          "500": {
-            "description": "Internal server error",
-            "content": {
-              "application/json": {
-                "schema": {
-                  "$ref": "#/components/schemas/Error"
-                },
-                "examples": {
-                  "INTERNAL_ERROR": {
-                    "value": {
-                      "error": {
-                        "message": "Internal error occurred. Please contact us if the error persists.",
-                        "code": "INTERNAL_ERROR",
-                        "id": "5d37dbcb-891e-41ca-a3d6-e690c97775ac"
-                      }
-                    }
-                  }
-                }
-              }
-            }
+        "security": [
+          {
+            "bearerAuth": []
           }
-        }
-      },
-      "post": {
-        "operationId": "notes/featured",
-        "summary": "notes/featured",
-        "description": "No description provided.\n\n**Credential required**: *No*",
-        "externalDocs": {
-          "description": "Source code",
-          "url": "https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/notes/featured.ts"
-        },
-        "tags": [
-          "notes"
         ],
         "requestBody": {
           "required": true,
@@ -62595,6 +62438,15 @@
                   "$ref": "#/components/schemas/Error"
                 },
                 "examples": {
+                  "ACCESS_DENIED": {
+                    "value": {
+                      "error": {
+                        "message": "Access denied.",
+                        "code": "ACCESS_DENIED",
+                        "id": "1f52fa0c-0873-436b-9888-df7ca85679d0"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {

Get diff files from Workflow Page

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 64.52%. Comparing base (40ff7d3) to head (ca55116).

Files Patch % Lines
packages/backend/src/server/api/endpoints/users.ts 69.23% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           develop-mame      #19     +/-   ##
===============================================
  Coverage         64.51%   64.52%             
===============================================
  Files               986      986             
  Lines            111195   111208     +13     
  Branches           5661     5710     +49     
===============================================
+ Hits              71739    71755     +16     
- Misses            38008    39421   +1413     
+ Partials           1448       32   -1416     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzukimame adzukimame merged commit 3f7fa20 into develop-mame Mar 25, 2024
22 checks passed
@adzukimame adzukimame deleted the hide-featured-notes branch May 12, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant