Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: キューのエラーログを簡略化するように #315

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

adzukimame
Copy link
Owner

What

  • fix(backend): キューのエラーログを簡略化するように (# 14748)

Why

Additional info (optional)

* reduce federation log spam

* Don't record stack trace for unrecoverable errors.
* Avoid logging duplicate stace traces.

(cherry picked from commit ed05701)

* improve error summaries

(cherry picked from commit 20dd66f)

* fix lint errors

(cherry picked from commit 83869e1)

* condense job info

(cherry picked from commit 786702e)

* fix maxAttempts calculation

(cherry picked from commit b4d10aa)

* condense error info

(cherry picked from commit f62cd89)

* normalize ID logging

(cherry picked from commit d8e1e48)

* further condense error details

(cherry picked from commit d867c20)

* collapse AbortErrors

(cherry picked from commit 5171ba7)

* don't log job name unless it has one

(cherry picked from commit a5316c0)

* Update Changelog

* Record origin

---------

Co-authored-by: Hazel K <[email protected]>
Copy link

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 35 lines in your changes missing coverage. Please review.

Project coverage is 43.53%. Comparing base (9dc9682) to head (e4b8078).
Report is 1 commits behind head on develop-mame.

Files with missing lines Patch % Lines
...ackages/backend/src/queue/QueueProcessorService.ts 22.22% 35 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           develop-mame     #315   +/-   ##
=============================================
  Coverage         43.53%   43.53%           
=============================================
  Files              1199     1199           
  Lines            151516   151526   +10     
  Branches           3465     3465           
=============================================
+ Hits              65968    65974    +6     
- Misses            85548    85552    +4     
Flag Coverage Δ
backend_e2e 55.60% <22.22%> (-0.01%) ⬇️
backend_unit 27.69% <0.00%> (+<0.01%) ⬆️
frontend_vitest 25.58% <ø> (ø)
misskey-js 92.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzukimame adzukimame merged commit e48b030 into develop-mame Nov 28, 2024
36 checks passed
@adzukimame adzukimame deleted the simplify-queue-error-logs branch November 28, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants