Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

通知音やノート・リアクション時の効果音を削除 #337

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

adzukimame
Copy link
Owner

What

Why

Additional info (optional)

  • クライアントで音を鳴らす機能はすべて削除したはず

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 43.59%. Comparing base (7329ad4) to head (bfd80ef).
Report is 1 commits behind head on develop-mame.

Files with missing lines Patch % Lines
packages/frontend/src/store.ts 0.00% 1 Missing ⚠️
packages/frontend/src/ui/deck/antenna-column.vue 0.00% 1 Missing ⚠️
packages/frontend/src/ui/deck/channel-column.vue 0.00% 1 Missing ⚠️
packages/frontend/src/ui/deck/list-column.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           develop-mame     #337      +/-   ##
================================================
+ Coverage         43.44%   43.59%   +0.15%     
================================================
  Files              1198     1194       -4     
  Lines            151712   150884     -828     
  Branches           3472     3469       -3     
================================================
- Hits              65912    65781     -131     
+ Misses            85800    85103     -697     
Flag Coverage Δ
frontend_vitest 25.57% <0.00%> (+0.10%) ⬆️
misskey-js 92.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzukimame adzukimame merged commit 7eb787d into develop-mame Dec 3, 2024
23 checks passed
@adzukimame adzukimame deleted the remove-client-notification-sound branch December 3, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant