Feat: add test and fix log

app/core/groups/endpoints_groups.py

@@ -329,7 +329,7 @@ async def synchronize_group_with_association(
         raise HTTPException(status_code=404, detail="Group not found")
 
     hyperion_security_logger.warning(
-        f"Synchronize_group_with_association: Admin user {user.id} ({user.name}) synchronized group {group_db.id} ({group_db.name}) with association membership {association_membership.value} ({request_id})",
+        f"Synchronize_group_with_association: Admin user {user.id} synchronized group {group_db.id} ({group_db.name}) with association membership '{association_membership.value}' ({request_id})",
     )
     await cruds_groups.delete_membership_by_group_id(group_id=group_id, db=db)
 

tests/test_groups.py

@@ -1,23 +1,27 @@
+import uuid
+from datetime import UTC, date, datetime, timedelta
+
 import pytest_asyncio
 from fastapi.testclient import TestClient
 
 from app.core import models_core
 from app.core.groups.groups_type import GroupType
+from app.types.membership import AvailableAssociationMembership
 from tests.commons import (
     add_object_to_db,
     create_api_access_token,
     create_user_with_groups,
 )
 
 admin_user: models_core.CoreUser
-
+user_test: models_core.CoreUser
 
 id_test_eclair = "8aab79e7-1e15-456d-b6e2-11e4e9f77e4f"
 
 
 @pytest_asyncio.fixture(scope="module", autouse=True)
 async def init_objects() -> None:
-    global admin_user
+    global admin_user, user_test
 
     eclair = models_core.CoreGroup(
         id=id_test_eclair,
@@ -27,6 +31,32 @@ async def init_objects() -> None:
     await add_object_to_db(eclair)
 
     admin_user = await create_user_with_groups([GroupType.admin])
+    user_test = await create_user_with_groups([])
+
+    aeecl_membership_admin = models_core.CoreAssociationMembership(
+        id=uuid.uuid4(),
+        user_id=admin_user.id,
+        membership=AvailableAssociationMembership.aeecl,
+        start_date=date(2021, 9, 5),
+        end_date=date(2022, 9, 5),
+    )
+    useecl_membership_admin = models_core.CoreAssociationMembership(
+        id=uuid.uuid4(),
+        user_id=admin_user.id,
+        membership=AvailableAssociationMembership.useecl,
+        start_date=date(2021, 9, 5),
+        end_date=date(2027, 9, 5),
+    )
+    aeecl_membership_test = models_core.CoreAssociationMembership(
+        id=uuid.uuid4(),
+        user_id=user_test.id,
+        membership=AvailableAssociationMembership.aeecl,
+        start_date=date(2021, 9, 5),
+        end_date=datetime.now(tz=UTC).date() + timedelta(days=365),
+    )
+    await add_object_to_db(aeecl_membership_admin)
+    await add_object_to_db(useecl_membership_admin)
+    await add_object_to_db(aeecl_membership_test)
 
 
 def test_read_groups(client: TestClient) -> None:
@@ -106,3 +136,22 @@ def test_delete_membership(client: TestClient) -> None:
         headers={"Authorization": f"Bearer {token}"},
     )
     assert response.status_code == 204
+
+
+def test_sync_group_with_association_membership(client: TestClient) -> None:
+    token = create_api_access_token(admin_user)
+
+    response = client.patch(
+        f"/groups/{id_test_eclair}/sync/AEECL",
+        headers={"Authorization": f"Bearer {token}"},
+    )
+    assert response.status_code == 204
+
+    response = client.get(
+        f"/groups/{id_test_eclair}",
+        headers={"Authorization": f"Bearer {token}"},
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert len(data["members"]) == 1
+    assert data["members"][0]["id"] == str(user_test.id)