fix: use explicit cruds arguments

aeecleclair · Mar 15, 2024 · f877982 · f877982
1 parent 859c969
commit f877982
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/app/modules/loan/cruds_loan.py b/app/modules/loan/cruds_loan.py
@@ -1,3 +1,4 @@
+from datetime import datetime
 from typing import Sequence
 
 from sqlalchemy import delete, func, select, update
@@ -191,10 +192,18 @@ async def update_loan(
 async def update_loan_returned_status(
     loan_id: str,
     db: AsyncSession,
-    values: dict[str, object],
+    returned: bool,
+    returned_date: datetime,
 ):
     await db.execute(
-        update(models_loan.Loan).where(models_loan.Loan.id == loan_id).values(values)
+        update(models_loan.Loan)
+        .where(models_loan.Loan.id == loan_id)
+        .values(
+            {
+                "returned": returned,
+                "returned_date": returned_date,
+            }
+        )
     )
     await db.commit()
 

diff --git a/app/modules/loan/endpoints_loan.py b/app/modules/loan/endpoints_loan.py
@@ -793,12 +793,9 @@ async def return_loan(
                 detail=f"Invalid loan content {loan.id}, {item.id}",
             )
 
-    values = {
-        "returned": True,
-        "returned_date": datetime.now(timezone.utc),
-    }
-
-    await cruds_loan.update_loan_returned_status(loan_id=loan_id, db=db, values=values)
+    await cruds_loan.update_loan_returned_status(
+        loan_id=loan_id, db=db, returned=True, returned_date=datetime.now(timezone.utc)
+    )
 
 
 @module.router.post(