feat: support Pydantic V2 #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
- Coverage 78.56% 78.30% -0.26%
==========================================
Files 78 78
Lines 5482 5435 -47
==========================================
- Hits 4307 4256 -51
- Misses 1175 1179 +4 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
armanddidierjean
added
the
dependencies
armanddidierjean
force-pushed
the
pydantic-update
branch
from
4d90faf to
43e622b
Compare
Pokegali
force-pushed
the
pydantic-update
branch
from
43e622b to
8d74c0e
Compare
Merged
Pokegali
force-pushed
the
pydantic-update
branch
from
8e37840 to
52fb903
Compare
armanddidierjean
requested changes
Nov 29, 2023
armanddidierjean
force-pushed
the
pydantic-update
branch
from
52fb903 to
6f0414a
Compare
instead of a timedelta which is converted in an ISO 8601 str
Pokegali
force-pushed
the
pydantic-update
branch
from
f7c4080 to
6e7bac9
Compare
guillaumetavernier
approved these changes
Feb 22, 2024
Rotheem
approved these changes
Feb 23, 2024
armanddidierjean
approved these changes
Feb 23, 2024
guillaumetavernier
pushed a commit
that referenced
this pull request
Feb 29, 2024
### Description This PR moves all module-related files to `/app/modules`, and each module has its own directory. It also makes modules declare their own module object. Note: it is based on pydantic v2 (#281).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the necessary modifications in order to support Pydantic breaking changes !
HOWEVER, do not use in production already, please test it thoroughly to verify that everything is working.