Fix test_search_users #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
=======================================
Coverage 60.14% 60.14%
=======================================
Files 77 77
Lines 5397 5397
=======================================
Hits 3246 3246
Misses 2151 2151 ☔ View full report in Codecov by Sentry. |
Pokegali
force-pushed
the
fix-test-search-users
branch
from
652c02d to
fdf57c2
Compare
armanddidierjean
approved these changes
Nov 9, 2023
Jake-Ransom
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed test_users::test_search_users.
When there were more than 10 users in the students group, it would fail because it would try to compare all of the users from the group to the users returned by an endpoint that is limited to return up to 10 users only.
I've modified the test so that instead of a strict equality, it is now an inequality, meaning that the students returned by /users/search must be present in the group, but we don't need all of them
Checklist