Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix response model #303

Merged
merged 4 commits into from
Jan 14, 2024
Merged

Fix response model #303

merged 4 commits into from
Jan 14, 2024

Conversation

Petitoto
Copy link
Member

@Petitoto Petitoto commented Dec 4, 2023

Description

Fix some responses models in endpoints:

  • POST /tombola/raffles -> RaffleComplete
  • POST /calendar/events/ -> EventReturn

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the documentation, if necessary

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e12c1d) 78.11% compared to head (fc91f68) 78.11%.

❗ Current head fc91f68 differs from pull request most recent head b6fc1be. Consider uploading reports for the commit b6fc1be to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   78.11%   78.11%           
=======================================
  Files          77       77           
  Lines        5397     5397           
=======================================
  Hits         4216     4216           
  Misses       1181     1181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Petitoto Petitoto requested review from maximeroucher and armanddidierjean and removed request for maximeroucher December 6, 2023 18:53
@armanddidierjean armanddidierjean merged commit c207282 into main Jan 14, 2024
5 checks passed
@armanddidierjean armanddidierjean deleted the fix-response-model branch January 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants