Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommendation #313

Merged
merged 21 commits into from
Mar 16, 2024
Merged

Recommendation #313

merged 21 commits into from
Mar 16, 2024

Conversation

julien4215
Copy link
Contributor

New module recommendation

@codecov Codecov
Copy link

codecov bot commented Dec 26, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.02913% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.69%. Comparing base (dec83a1) to head (a7a3c2f).

Files Patch % Lines
...modules/recommendation/endpoints_recommendation.py 97.82% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   78.30%   78.69%   +0.39%     
==========================================
  Files          77       81       +4     
  Lines        5356     5459     +103     
==========================================
+ Hits         4194     4296     +102     
- Misses       1162     1163       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Petitoto Petitoto added the ready for review This PR is ready to be reviewed label Jan 9, 2024
armanddidierjean
armanddidierjean reviewed Jan 14, 2024
View reviewed changes
app/cruds/cruds_recommendation.py Outdated Show resolved Hide resolved
app/endpoints/recommendation.py Outdated Show resolved Hide resolved
@julien4215 julien4215 force-pushed the recommendation branch 2 times, most recently from 9ad4a50 to 7b9523a Compare February 23, 2024 18:57
armanddidierjean
armanddidierjean requested changes Feb 28, 2024
View reviewed changes
app/utils/types/module_list.py Outdated Show resolved Hide resolved
app/cruds/cruds_recommendation.py Outdated Show resolved Hide resolved
app/cruds/cruds_recommendation.py Outdated Show resolved Hide resolved
app/endpoints/recommendation.py Outdated Show resolved Hide resolved
app/endpoints/recommendation.py Outdated Show resolved Hide resolved
app/models/models_recommendation.py Outdated Show resolved Hide resolved
tests/test_recommendation.py Outdated Show resolved Hide resolved
tests/test_recommendation.py Show resolved Hide resolved
@armanddidierjean armanddidierjean mentioned this pull request Mar 2, 2024
Open
@julien4215 julien4215 force-pushed the recommendation branch 2 times, most recently from 6eeb4e6 to 78ba29f Compare March 16, 2024 05:48
@julien4215 julien4215 merged commit c1156a4 into main Mar 16, 2024
7 checks passed
@julien4215 julien4215 deleted the recommendation branch March 16, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumetavernier guillaumetavernier guillaumetavernier approved these changes

@armanddidierjean armanddidierjean armanddidierjean approved these changes

Assignees
No one assigned
Labels
module ready for review This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julien4215 @armanddidierjean @guillaumetavernier @Petitoto