Fix phonebook : kinds enum and types file #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
==========================================
- Coverage 80.47% 80.28% -0.20%
==========================================
Files 86 86
Lines 5766 5766
==========================================
- Hits 4640 4629 -11
- Misses 1126 1137 +11 ☔ View full report in Codecov by Sentry. |
| @@ -25,7 +25,19 @@ def upgrade() -> None: | |||
| sa.Column("id", sa.String(), nullable=False), | |||
| sa.Column("name", sa.String(), nullable=False), | |||
| sa.Column("description", sa.String(), nullable=True), | |||
| sa.Column("kind", sa.String(), nullable=False), | |||
| sa.Column( | |||
There was a problem hiding this comment.
Isn't it possible to use the enum define in type rather than hard code values twice?
There was a problem hiding this comment.
I'm not completely sure. If we change the enum in the future, we don't what changes to have an impact on existing migration files
julien4215
requested changes
Mar 20, 2024
julien4215
reviewed
Mar 20, 2024
julien4215
approved these changes
Mar 29, 2024
foucblg
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist