-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format and improve Alembic migration generation #396
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
=======================================
Coverage 80.47% 80.47%
=======================================
Files 86 86
Lines 5766 5766
=======================================
Hits 4640 4640
Misses 1126 1126 ☔ View full report in Codecov by Sentry. |
5475848
to
c3bd626
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could add a comment in the datetime.py file to explain that if we change the custom type then it might break the existing migrations.
instead of app/utils
477583d
to
310a562
Compare
Description
app.type.sqlalchemy.TZDateTime
in migration files for custom DATETIME objectsChecklist