Use jaro_winkler similarity instead of rapidfuzz #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
==========================================
- Coverage 83.12% 83.11% -0.02%
==========================================
Files 104 104
Lines 6412 6420 +8
==========================================
+ Hits 5330 5336 +6
- Misses 1082 1084 +2 ☔ View full report in Codecov by Sentry. |
| """ | ||
|
|
||
| # We can give a dictionary of {object: string used for the comparison} to the extract function | ||
| # https://maxbachmann.github.io/RapidFuzz/Usage/process.html#extract | ||
|
|
||
| # TODO: we may want to cache this object. Its generation may take some time if there is a big user base |
There was a problem hiding this comment.
Isn't it the time to do it ?
There was a problem hiding this comment.
Instead of caching we may explore the list generation in the database
https://docs.sqlalchemy.org/en/20/core/functions.html#sqlalchemy.sql.functions.concat
armanddidierjean
requested changes
Jul 20, 2024
Rotheem
force-pushed
the
better-user-search
branch
from
122c315 to
a9c42e7
Compare
Rotheem
force-pushed
the
better-user-search
branch
2 times, most recently
from
a6f73f5 to
eb7e4e5
Compare
armanddidierjean
force-pushed
the
better-user-search
branch
from
eb7e4e5 to
ed9de87
Compare
armanddidierjean
force-pushed
the
better-user-search
branch
from
ed9de87 to
cb09030
Compare
Malem38
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use jaro_winkler similarity from jellyfish module instead of rapidfuzz. It has the same speed and better results