Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use model_fields_set to check if at least a field is to be updated #532

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

armanddidierjean
Copy link
Member

to prevent False values to be interpreted as not provided fields

Related to #355

@armanddidierjean armanddidierjean added the bug Something isn't working label Aug 22, 2024
@armanddidierjean armanddidierjean force-pushed the dont-fail-for-only-false-patch branch from d8dfefe to ed5d14b Compare August 22, 2024 13:19
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.31%. Comparing base (1a5e843) to head (eb80c9e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #532   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files         113      113           
  Lines        8110     8110           
=======================================
  Hits         6757     6757           
  Misses       1353     1353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

to prevent `False` values to be interpreted as not provided fields
@armanddidierjean armanddidierjean force-pushed the dont-fail-for-only-false-patch branch from ed5d14b to eb80c9e Compare August 23, 2024 14:52
@Rotheem Rotheem merged commit 39aa9b3 into main Aug 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants