MyECLPay #611
Draft
MyECLPay #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanddidierjean
force-pushed
the
myeclpay
branch
2 times, most recently
from
47f1137 to
1777ada
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
+ Coverage 81.06% 81.42% +0.35%
==========================================
Files 134 140 +6
Lines 10319 11104 +785
==========================================
+ Hits 8365 9041 +676
- Misses 1954 2063 +109 ☔ View full report in Codecov by Sentry. |
armanddidierjean
force-pushed
the
myeclpay
branch
from
e607172 to
aaeaf83
Compare
foucblg
pushed a commit
that referenced
this pull request
Jan 6, 2025
> [!IMPORTANT] > We really need to release new versions **soon**, as we have not for several months and there's some time needed to test in alpha before prod. This goes hand in hand with the **major version bump** [for Titan](../../Titan/pull/462). Both PRs are ready, and _seemingly_ waiting for some more **breaking changes** to be merged, including (by likelihood): - [ ] Allow students from other Schools to have a MyECL account: #641 - [ ] MyECLPay: #611 - [ ] "_Centrale Mega Meme_" Meme module: [no PR yet] [see branch](../tree/cmm) - [x] External Notifications: #613
Co-authored-by: Maxime Roucher <[email protected]>
Co-authored-by: Maxime Roucher <[email protected]>
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist