Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Matrix server url defined in dotenv #625

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

armanddidierjean
Copy link
Member

instead of matrix.org

instead of matrix.org
@armanddidierjean armanddidierjean added the fix bug This PR fix a bug label Dec 2, 2024
@armanddidierjean armanddidierjean changed the title Use server url defined in dotenv Use Matrix server url defined in dotenv Dec 2, 2024
@Daihecyy
Copy link
Contributor

Daihecyy commented Dec 2, 2024

I think having only one url will reduce code complexity

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.24%. Comparing base (495233c) to head (d8e9acd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #625   +/-   ##
=======================================
  Coverage   81.24%   81.24%           
=======================================
  Files         128      128           
  Lines        9950     9950           
=======================================
  Hits         8084     8084           
  Misses       1866     1866           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rotheem Rotheem merged commit 5a2ecda into main Dec 2, 2024
9 checks passed
@Rotheem Rotheem deleted the matrix-use-server-url branch December 2, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix bug This PR fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants