-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jinja templating #629
Jinja templating #629
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
+ Coverage 81.24% 81.31% +0.06%
==========================================
Files 128 129 +1
Lines 9950 10013 +63
==========================================
+ Hits 8084 8142 +58
- Misses 1866 1871 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice refactoring!
I could argue on some rewritings of the English translations which you made while you were at it (why not having a separate PR for that? that's not the point of this PR).
But I won't bother you on it for now (on this PR at least!), bc I'd like it to be merged.
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
7298663 | Triggered | RSA Private Key | c6e9921 | .env.test | View secret |
7298664 | Triggered | Generic Password | c6e9921 | tests/test_auth.py | View secret |
7298668 | Triggered | Generic High Entropy Secret | c6e9921 | .env.test | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Description
Changed email templates to use a Jinja base template, created a python helper function to test the templates and improved phrasing