Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jinja templating #629

Merged
merged 11 commits into from
Jan 3, 2025
Merged

Jinja templating #629

merged 11 commits into from
Jan 3, 2025

Conversation

Daihecyy
Copy link
Contributor

@Daihecyy Daihecyy commented Dec 4, 2024

Description

Changed email templates to use a Jinja base template, created a python helper function to test the templates and improved phrasing

@Daihecyy Daihecyy linked an issue Dec 4, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.31%. Comparing base (5a2ecda) to head (6bea30e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
+ Coverage   81.24%   81.31%   +0.06%     
==========================================
  Files         128      129       +1     
  Lines        9950    10013      +63     
==========================================
+ Hits         8084     8142      +58     
- Misses       1866     1871       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@armanddidierjean armanddidierjean added enhancement New feature or request jinja labels Dec 5, 2024
@Daihecyy Daihecyy added the invalid This doesn't seem right label Dec 5, 2024
@Daihecyy Daihecyy closed this Dec 5, 2024
@Daihecyy Daihecyy removed the invalid This doesn't seem right label Dec 5, 2024
@Daihecyy Daihecyy reopened this Dec 5, 2024
Copy link
Contributor

@Marc-Andrieu Marc-Andrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice refactoring!

I could argue on some rewritings of the English translations which you made while you were at it (why not having a separate PR for that? that's not the point of this PR).
But I won't bother you on it for now (on this PR at least!), bc I'd like it to be merged.

@aeecleclair aeecleclair deleted a comment from armanddidierjean Dec 16, 2024
@aeecleclair aeecleclair deleted a comment from Daihecyy Dec 16, 2024
@aeecleclair aeecleclair deleted a comment from Daihecyy Dec 16, 2024
Copy link

gitguardian bot commented Jan 2, 2025

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7298663 Triggered RSA Private Key c6e9921 .env.test View secret
7298664 Triggered Generic Password c6e9921 tests/test_auth.py View secret
7298668 Triggered Generic High Entropy Secret c6e9921 .env.test View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Marc-Andrieu Marc-Andrieu added ready for review This PR is ready to be reviewed code quality labels Jan 3, 2025
@Rotheem Rotheem merged commit a748e91 into main Jan 3, 2025
4 of 5 checks passed
@Rotheem Rotheem deleted the jinja-templating branch January 3, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality enhancement New feature or request jinja ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inherit jinja templates from a base templates
4 participants