Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: changed file format of a default cover from .jpg to .jpeg #636

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

KirillBorodinskiy
Copy link
Contributor

@KirillBorodinskiy KirillBorodinskiy commented Dec 20, 2024

Description

This should resolve issue #635

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the documentation, if necessary

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.31%. Comparing base (948ce9f) to head (68bd7c4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #636   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files         129      129           
  Lines       10013    10013           
=======================================
  Hits         8142     8142           
  Misses       1871     1871           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KirillBorodinskiy
Copy link
Contributor Author

I am sorry, but I am not yet familiar with such a system of merging. When will those tests be marked as done?

@Rotheem
Copy link
Member

Rotheem commented Dec 22, 2024

I am sorry, but I am not yet familiar with such a system of merging. When will those tests be marked as done?

There seems to be an issue with 2 checks, we will ignore them

@Rotheem Rotheem merged commit 5f2433a into aeecleclair:main Dec 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants