Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spliting for web #211

Merged
merged 18 commits into from
Nov 18, 2023
Merged

Spliting for web #211

merged 18 commits into from
Nov 18, 2023

Conversation

maximeroucher
Copy link
Member

@maximeroucher maximeroucher commented Nov 17, 2023 •
edited
Loading

Using deferred loading in middleware to split main_dart.js in multiple files to make it faster to load

image

@maximeroucher
feat: adding deferred loading middleware
a6df442
@maximeroucher
fix: name
476d63b
@maximeroucher
feat: applying deferred loading to admin module
d595398
@maximeroucher
feat: adding deferred loading to advert module
42a350e
@maximeroucher
feat: adding deferred loading to amap module
77f5c14
@maximeroucher
feat: adding deferred loading to booking module
0110e03
@maximeroucher
feat: adding deferred loading to centralisation module
85a82aa
@maximeroucher
feat: adding deferred loading to cinema module
b81a18e
@maximeroucher
feat: adding deferred loading to event module
1683645
@maximeroucher
feat: adding deferred loading to home module
57ef98d
@maximeroucher
feat: adding deferred loading to loan module
4300271
@maximeroucher
feat: adding deferred loading to login module
5f17b4d
@maximeroucher
feat: adding deferred loading to raffle module
0a1f62a
@maximeroucher
feat: adding deferred loading to settings module
b5bf07e
@maximeroucher
feat: adding deferred loading to vote module
bddb962
@maximeroucher
feat: adding deferred loading to main router
49a505d
@maximeroucher
fix: replacing scaffold
cf59055
@maximeroucher
lint: applying lint
c0b7e07
@maximeroucher maximeroucher added ready for review This PR is ready to be reviewed web labels Nov 17, 2023
@maximeroucher maximeroucher linked an issue Nov 17, 2023 that may be closed by this pull request
Split main.dart.js #119
Closed
@Petitoto
Copy link
Member

Partially solves #119
Big improvement: main.dart.js size is now "only" 3,2 Mo (vs more than 5 Mo before)
We could still improve the splitting by splitting more classes, and by removing useless strings in main.dart.js

@maximeroucher maximeroucher merged commit 8819bbc into main Nov 18, 2023
@armanddidierjean armanddidierjean deleted the spliting-for-web branch November 19, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Petitoto Petitoto Petitoto approved these changes

@armanddidierjean armanddidierjean armanddidierjean approved these changes

Assignees
No one assigned
Labels
ready for review This PR is ready to be reviewed web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split main.dart.js
3 participants
@maximeroucher @Petitoto @armanddidierjean