Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add auth enabler #204

Merged
merged 8 commits into from
Jun 13, 2024
Merged

add auth enabler #204

merged 8 commits into from
Jun 13, 2024

Conversation

Kirill-Garbar
Copy link
Collaborator

@Kirill-Garbar Kirill-Garbar commented May 6, 2024

fixes #160

Changelog

Added

  • [chart+kustomize]
    • what: Added get secrets permissions for operator namespace.
    • why: Necessary for operator to get secrets with certificates.
  • [api]
    • what: Added helper functions to let getting settings easier.
    • why: Unify getting settings throughout the project code.
  • [api]
    • what: Added ServerTrustedCASecret to spec.
    • why: Necessary to mount this certificate to let operator trust etcd cluster.
  • [controller]
    • what: Added functionality to disable and enable auth, add root role, root user.
    • why: Necessary for the customer.

Changed

  • [api]
    • what: Adjusted field descriptions for security fields.
    • why: Necessary to let customers know where we expect created secrets with certificates.
  • [etcdcluster_controller_test]
    • what: Commented autotests that reconcile twice and set sts ready.
    • why: Not clear how to handle failed tests. It is not supposed to set ready status when it is not ready. Creating mocks for every function that uses etcdClient will take much time in the future

@github-actions github-actions bot added controllers feature New feature or request api-change labels May 6, 2024
@kvaps kvaps mentioned this pull request May 28, 2024
@Kirill-Garbar Kirill-Garbar force-pushed the feature/enableAuth branch 4 times, most recently from e807b16 to 2f530a4 Compare June 2, 2024 22:34
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 4, 2024
@Kirill-Garbar Kirill-Garbar force-pushed the feature/enableAuth branch 2 times, most recently from f954006 to e47886e Compare June 6, 2024 10:55
@Kirill-Garbar Kirill-Garbar force-pushed the feature/enableAuth branch 3 times, most recently from 4ae2408 to ef044e4 Compare June 6, 2024 22:12
@Kirill-Garbar Kirill-Garbar marked this pull request as ready for review June 6, 2024 22:22
Copy link
Collaborator

@aobort aobort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kirill-Garbar Kirill-Garbar merged commit 9978183 into main Jun 13, 2024
9 checks passed
@Kirill-Garbar Kirill-Garbar deleted the feature/enableAuth branch June 13, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change controllers documentation Improvements or additions to documentation feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a flag to enable etcd auth
4 participants