Skip to content

Commit

Permalink
[MNT] Trying to diagnose ubuntu workflow failures (#2413)
Browse files Browse the repository at this point in the history
* fix main workflow conditions

* try downgrade ubuntu

* latest image

* swap space

* linux only

* periodic and release also
  • Loading branch information
MatthewMiddlehurst authored Nov 28, 2024
1 parent 225c2b6 commit 6c22d20
Show file tree
Hide file tree
Showing 17 changed files with 51 additions and 33 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/fast_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
build-project:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- uses: actions/checkout@v4
Expand All @@ -28,7 +28,7 @@ jobs:
retention-days: 5

upload-wheels:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- uses: actions/download-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue_assigned.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ concurrency:

jobs:
remove-good-first-issue:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Create app token
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue_comment_edited.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ concurrency:
jobs:
pr-welcome-edited:
if: ${{ github.event.issue.pull_request }}
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Create app token
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue_comment_posted.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
self-assign:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/periodic_github_maintenace.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ permissions:

jobs:
stale_branches:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Create app token
Expand Down
20 changes: 13 additions & 7 deletions .github/workflows/periodic_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ concurrency:

jobs:
check-manifest:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand All @@ -29,7 +29,7 @@ jobs:
extra_args: check-manifest --hook-stage manual

pre-commit:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand All @@ -46,7 +46,7 @@ jobs:
extra_args: --all-files

run-notebook-examples:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand Down Expand Up @@ -84,7 +84,7 @@ jobs:
key: numba-run-notebook-examples-${{ runner.os }}-3.10-${{ env.CURRENT_DATE }}

test-core-imports:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand All @@ -109,7 +109,7 @@ jobs:
run: python aeon/testing/tests/test_core_imports.py

test-no-soft-deps:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand Down Expand Up @@ -154,7 +154,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ ubuntu-22.04, macOS-14, windows-2022 ]
os: [ ubuntu-24.04, macOS-14, windows-2022 ]
python-version: [ "3.9", "3.10", "3.11", "3.12" ]

steps:
Expand All @@ -166,6 +166,12 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Set swap space
if: runner.os == 'Linux'
uses: pierotofy/[email protected]
with:
swap-size-gb: 10

- name: Use numba cache to set env variables but not restore cache
uses: ./.github/actions/numba_cache
with:
Expand Down Expand Up @@ -195,7 +201,7 @@ jobs:
key: numba-pytest-${{ runner.os }}-${{ matrix.python-version}}-${{ env.CURRENT_DATE }}

codecov:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr_core_dep_import.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ concurrency:

jobs:
test-core-imports:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pr_examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ concurrency:

jobs:
run-notebook-examples:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand All @@ -30,7 +30,7 @@ jobs:
with:
python-version: "3.10"

- if: ${{ github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'no numba cache') }}
- if: ${{ github.event_name != 'pull_request' || !contains(github.event.pull_request.labels.*.name, 'no numba cache') }}
name: Restore numba cache
uses: ./.github/actions/numba_cache
with:
Expand All @@ -46,5 +46,5 @@ jobs:
command: python -m pip install .[all_extras,binder,dev]

- name: Run example notebooks
run: .github/utilities/run_examples.sh ${{ github.event_name != 'pull_request' || !contains(github.event.pull_request.labels.*.name, 'full examples run') }}
run: .github/utilities/run_examples.sh ${{ github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'full examples run') }}
shell: bash
2 changes: 1 addition & 1 deletion .github/workflows/pr_opened.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ permissions:
jobs:
# based on the scikit-learn 1.3.1 PR labelers
labeler:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr_precommit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ concurrency:

jobs:
pre-commit:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Create app token
Expand Down
16 changes: 11 additions & 5 deletions .github/workflows/pr_pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ concurrency:

jobs:
test-no-soft-deps:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand All @@ -29,7 +29,7 @@ jobs:
with:
python-version: "3.10"

- if: ${{ github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'no numba cache') }}
- if: ${{ github.event_name != 'pull_request' || !contains(github.event.pull_request.labels.*.name, 'no numba cache') }}
name: Restore numba cache
uses: ./.github/actions/numba_cache
with:
Expand All @@ -56,7 +56,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ ubuntu-22.04, macOS-14, windows-2022 ]
os: [ ubuntu-24.04, macOS-14, windows-2022 ]
python-version: [ "3.9", "3.10", "3.11", "3.12" ]
# skip python versions unless the PR has the 'full pytest actions' label
pr-testing:
Expand All @@ -74,7 +74,13 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- if: ${{ github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'no numba cache') }}
- name: Set swap space
if: runner.os == 'Linux'
uses: pierotofy/[email protected]
with:
swap-size-gb: 10

- if: ${{ github.event_name != 'pull_request' || !contains(github.event.pull_request.labels.*.name, 'no numba cache') }}
name: Restore numba cache
uses: ./.github/actions/numba_cache
with:
Expand All @@ -100,7 +106,7 @@ jobs:
# run the code coverage job if a PR has the 'codecov actions' label
if: ${{ github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'codecov actions') }}

runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr_typecheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
typecheck:
# run the code coverage job if a PR has the '' label
if: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'run typecheck test') }}
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/precommit_autoupdate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
pre-commit-auto-update:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- uses: actions/checkout@v4
Expand Down
14 changes: 10 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
check-manifest:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- uses: actions/checkout@v4
Expand All @@ -23,7 +23,7 @@ jobs:

build-project:
needs: check-manifest
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ ubuntu-22.04, macOS-14, windows-2022 ]
os: [ ubuntu-24.04, macOS-14, windows-2022 ]
python-version: [ "3.9", "3.10", "3.11", "3.12" ]

steps:
Expand All @@ -61,6 +61,12 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Set swap space
if: runner.os == 'Linux'
uses: pierotofy/[email protected]
with:
swap-size-gb: 10

- uses: actions/download-artifact@v4
with:
name: dist
Expand Down Expand Up @@ -93,7 +99,7 @@ jobs:

upload-wheels:
needs: test-wheels
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- uses: actions/download-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scorecard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ permissions: read-all
jobs:
analysis:
name: Scorecard analysis
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
permissions:
# Needed to upload the results to code-scanning dashboard.
security-events: write
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update_contributors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

jobs:
generate-markdown-and-commit:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ python:
- docs

build:
os: ubuntu-22.04
os: ubuntu-24.04
tools:
python: "3.10"

Expand Down

0 comments on commit 6c22d20

Please sign in to comment.