Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] The Default value for use_mini_batch_size should be set to False #1065

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

andregdmitri
Copy link
Contributor

@andregdmitri andregdmitri commented Jan 18, 2024

What does this implement/fix? Explain your changes.

The default value of '''use_mini_batch_size''' should be set to '''False''' for FCN, most of the time FCN will not be used with mini_batch.

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

@andregdmitri
Copy link
Contributor Author

@all-contributors please add @andregdmitri for code

@aeon-actions-bot aeon-actions-bot bot added the regression Regression package label Jan 18, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$, $\color{#7E0206}{\textsf{regression}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

Copy link
Contributor

@andregdmitri

I've put up a pull request to add @andregdmitri! 🎉

@andregdmitri andregdmitri changed the title The Default value for use_mini_batch_size should be set to False [MNT] The Default value for use_mini_batch_size should be set to False Jan 18, 2024
@andregdmitri andregdmitri changed the title [MNT] The Default value for use_mini_batch_size should be set to False [ENH] The Default value for use_mini_batch_size should be set to False Jan 18, 2024
@MatthewMiddlehurst MatthewMiddlehurst added the enhancement New feature, improvement request or other non-bug code enhancement label Jan 18, 2024
Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this ! congrats on your first contribution

@hadifawaz1999 hadifawaz1999 merged commit de9dff8 into aeon-toolkit:main Jan 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement regression Regression package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants