Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Fixed the default use_mini_batch_size value in resnet #1073

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

jose-gilberto
Copy link
Contributor

@jose-gilberto jose-gilberto commented Jan 19, 2024

What does this implement/fix? Explain your changes.

Change to False the default value for use_mini_batch_size in resnet for both classification and regression (the docstring already used False as the default value)

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

@aeon-actions-bot aeon-actions-bot bot added classification Classification package refactor Restructuring without changing its external behavior regression Regression package labels Jan 19, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#BDD9DB}{\textsf{refactor}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$, $\color{#7E0206}{\textsf{regression}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@jose-gilberto
Copy link
Contributor Author

@all-contributors please add @jose-gilberto for code.

Copy link
Contributor

@jose-gilberto

I've put up a pull request to add @jose-gilberto! 🎉

Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! congrats on your first contribution

@hadifawaz1999 hadifawaz1999 added the deep learning Deep learning related label Jan 19, 2024
@hadifawaz1999 hadifawaz1999 merged commit 2f8292b into aeon-toolkit:main Jan 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package deep learning Deep learning related refactor Restructuring without changing its external behavior regression Regression package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants