Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Wrong bound on sklearn for sparse argument #1112

Merged
merged 1 commit into from
Jan 26, 2024
Merged

[BUG] Wrong bound on sklearn for sparse argument #1112

merged 1 commit into from
Jan 26, 2024

Conversation

julu98
Copy link
Contributor

@julu98 julu98 commented Jan 26, 2024

Reference Issues/PRs

Fixes #1109

What does this implement/fix? Explain your changes.

Corrected threshold for change of sparse argument name from sklearn version 1.1 to 1.2

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

@aeon-actions-bot aeon-actions-bot bot added bug Something isn't working classification Classification package labels Jan 26, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@TonyBagnall
Copy link
Contributor

@all-contributors please add @julu98 for bug

Copy link
Contributor

@TonyBagnall

I've put up a pull request to add @julu98! 🎉

@aeon-toolkit aeon-toolkit deleted a comment from allcontributors bot Jan 26, 2024
@TonyBagnall TonyBagnall merged commit 73fe1b0 into aeon-toolkit:main Jan 26, 2024
19 checks passed
@julu98 julu98 deleted the bugfix/issue-1109 branch January 26, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working classification Classification package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Wrong version threshold for changing name of argument when calling sklearn.preprocessing.OneHotEncoder
2 participants