-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT]Use Numpy Vectorization in ContinuosIntervalTree fit method #1345 #2141
Conversation
Thank you for contributing to
|
Could you please fill out the PR template and give an informative title, thanks. |
@all-contributors please add @LinGinQiu for MNT#1345 |
I couldn't determine any contributions to add, did you specify any contributions? |
@all-contributors please add @LinGinQiu for for code |
I've put up a pull request to add @LinGinQiu! 🎉 |
Hello, is it right now? |
thanks, but could you write a brief description in the actual comment? i.e. fill in anything here? Reference Issues/PRs What does this implement/fix? Explain your changes. Does your contribution introduce a new dependency? If yes, which one? Any other comments? |
Yes, I will do that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Reference Issues/PRs
#1345
What does this implement/fix? Explain your changes.
Using numpy.unique to replace the original code as suggested in #1345
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
Thing goes well, and thank aeon to let me know the pipeline about a repo
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access