Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT]Use Numpy Vectorization in ContinuosIntervalTree fit method #1345 #2141

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

LinGinQiu
Copy link
Contributor

@LinGinQiu LinGinQiu commented Oct 3, 2024

Reference Issues/PRs

#1345

What does this implement/fix? Explain your changes.

Using numpy.unique to replace the original code as suggested in #1345

Does your contribution introduce a new dependency? If yes, which one?

No

Any other comments?

Thing goes well, and thank aeon to let me know the pipeline about a repo

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@aeon-actions-bot aeon-actions-bot bot added the classification Classification package label Oct 3, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst
Copy link
Member

Could you please fill out the PR template and give an informative title, thanks.

@LinGinQiu LinGinQiu changed the title Assigned #1345 to @LinGinQiu. [MNT]Use Numpy Vectorization in ContinuosIntervalTree fit method #1345 Oct 3, 2024
@LinGinQiu
Copy link
Contributor Author

@all-contributors please add @LinGinQiu for MNT#1345

Copy link
Contributor

@LinGinQiu

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@LinGinQiu
Copy link
Contributor Author

@all-contributors please add @LinGinQiu for for code

Copy link
Contributor

@LinGinQiu

I've put up a pull request to add @LinGinQiu! 🎉

@LinGinQiu
Copy link
Contributor Author

Could you please fill out the PR template and give an informative title, thanks.

Hello, is it right now?

@TonyBagnall
Copy link
Contributor

thanks, but could you write a brief description in the actual comment? i.e. fill in anything here?

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

Any other comments?

@LinGinQiu
Copy link
Contributor Author

thanks, but could you write a brief description in the actual comment? i.e. fill in anything here?

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

Any other comments?

Yes, I will do that

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@MatthewMiddlehurst MatthewMiddlehurst added the enhancement New feature, improvement request or other non-bug code enhancement label Oct 3, 2024
@TonyBagnall TonyBagnall merged commit 845eb37 into aeon-toolkit:main Oct 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants