-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Implemented Tracking differentiator-based multiview dilated characteristics (TD-MVDC) Classifier #2535
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for contributing to
|
@CCHe64 this is the current implementation of the classifier. Other tasks such as testing and multithreading needs to be added. Will do that once the accuracy discrepancy is resolved. |
Is tsfreshrelevant used now? The original paper used 777 full feature versions of tsfresh. Is the accuracy difference because of this? |
This reverts commit 9153909.
Reference Issues/PRs
Closes #2081.
What does this implement/fix? Explain your changes.
This PR implements the TDMVDC classifier.
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
Currently using the TSFreshRelevant feature extractor for feature extraction. I have tried implementing a similar module (for feature extraction) dedicated for tdmvdc itself (doesn't give great results).
Accuracy as per paper: 81.14 per cent
Obtained accuracy: 77.71 per cent
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access