Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fail to dail to xds istiod.istio-system.svc:15012 #402

Merged

Conversation

shencurl521
Copy link
Contributor

@shencurl521 shencurl521 commented Dec 12, 2023

issue :#389

@mergify mergify bot requested a review from zhaohuabing December 12, 2023 12:08
@zhaohuabing
Copy link
Member

@shencurl521 Could you please sign the commits in this PR?

https://github.com/aeraki-mesh/aeraki/pull/402/checks?check_run_id=19555129630

@shencurl521 shencurl521 force-pushed the fix_fail_to_connect_istiod branch from 202f209 to 52fb1da Compare December 16, 2023 06:37
@shencurl521
Copy link
Contributor Author

@shencurl521 Could you please sign the commits in this PR?

https://github.com/aeraki-mesh/aeraki/pull/402/checks?check_run_id=19555129630

sorry format incorrect

@zhaohuabing
Copy link
Member

zhaohuabing commented Dec 16, 2023

Please fix the go lint issue.

@shencurl521 shencurl521 force-pushed the fix_fail_to_connect_istiod branch from 52fb1da to b077092 Compare January 9, 2024 13:52
@shencurl521 shencurl521 force-pushed the fix_fail_to_connect_istiod branch from b077092 to 0930179 Compare January 10, 2024 02:52
@shencurl521
Copy link
Contributor Author

Please fix the go lint issue.
fixed

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@zhaohuabing zhaohuabing merged commit b98c319 into aeraki-mesh:master Jan 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants