Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add system.toAddress() and system.toPubkey() #193

Merged
merged 17 commits into from
May 17, 2024
Merged

add system.toAddress() and system.toPubkey() #193

merged 17 commits into from
May 17, 2024

Conversation

kroggen
Copy link
Member

@kroggen kroggen commented May 3, 2023 •
edited
Loading

Closes #142

system.toPubkey(address): convert an address to a public key
system.toAddress(pubkey): convert a public key to an address

@kroggen kroggen linked an issue May 3, 2023 that may be closed by this pull request
Smart contracts: convert between address and public key #142
Closed
@kroggen kroggen changed the base branch from master to develop May 4, 2023 17:03
@kroggen kroggen marked this pull request as draft May 11, 2023 01:48
@kroggen kroggen added check hardfork Run sync test with the PR V4 To be released on hardfork V4 labels Jul 7, 2023
@kroggen
Copy link
Member Author

kroggen commented Jul 19, 2023 •
edited
Loading

TODO:

  • add functional tests
  • add gas test (gas-per-function)

@kroggen kroggen changed the base branch from develop to topic/hardfork-v4 October 6, 2023 04:17
@kroggen kroggen force-pushed the feature/toaddress+topubkey branch from 45e65c1 to 154e7c9 Compare October 6, 2023 04:32
@kroggen
Copy link
Member Author

kroggen commented Oct 18, 2023

It is giving this error message when passing a nil:

bad argument #1 to '?' (string expected, got nil)

Instead of ? it should display the function name...

@kroggen kroggen marked this pull request as ready for review October 18, 2023 14:44
@kroggen kroggen added feature New feature or request and removed check hardfork Run sync test with the PR labels Nov 9, 2023
hayarobi
hayarobi approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@hayarobi hayarobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kroggen kroggen merged commit e329eb5 into topic/hardfork-v4 May 17, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayarobi hayarobi hayarobi approved these changes

@rabbitprincess rabbitprincess Awaiting requested review from rabbitprincess

Assignees
No one assigned
Labels
feature New feature or request V4 To be released on hardfork V4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smart contracts: convert between address and public key
2 participants
@kroggen @hayarobi