Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system.date() and system.time() #274

Merged
merged 8 commits into from
Nov 13, 2023
Merged

system.date() and system.time() #274

merged 8 commits into from
Nov 13, 2023

Conversation

kroggen
Copy link
Member

@kroggen kroggen commented Oct 3, 2023

This PR prepares the system.date() and system.time() functions to be made public

The result of these functions must be deterministic

@kroggen
Copy link
Member Author

kroggen commented Oct 3, 2023

Check the discussion here

@kroggen kroggen added the check hardfork Run sync test with the PR label Oct 3, 2023
@kroggen
Copy link
Member Author

kroggen commented Oct 19, 2023

@kslee8282 This PR is also ready to run a sync test

@kslee8282
Copy link
Member

kslee8282 commented Oct 23, 2023 •
edited
Loading

@kslee8282 This PR is also ready to run a sync test

start sync testnet
Oct 23 02:12:48.586 INF ../go/aergo/cmd/aergosvr/aergosvr.go:100 > AERGO SVR STARTED branch=topic/datetime module=asvr revision=3293a551

start sync mainnet
Oct 23 02:18:04.282 INF ../go/aergo/cmd/aergosvr/aergosvr.go:100 > AERGO SVR STARTED branch=topic/datetime module=asvr revision=3293a551

@kroggen
Copy link
Member Author

kroggen commented Oct 28, 2023

@kslee8282
Did this pass the sync tests?

@kslee8282
Copy link
Member

sync success

@kslee8282 kslee8282 added the pass sync test The PR can be merged label Oct 30, 2023
@kroggen
Copy link
Member Author

kroggen commented Oct 30, 2023

@hayarobi @gokch
The notes about this PR is here

hayarobi
hayarobi approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@hayarobi hayarobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kroggen kroggen merged commit 94d98b7 into develop Nov 13, 2023
@kroggen kroggen deleted the topic/datetime branch November 13, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabbitprincess rabbitprincess rabbitprincess approved these changes

@hayarobi hayarobi hayarobi approved these changes

Assignees
No one assigned
Labels
check hardfork Run sync test with the PR pass sync test The PR can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kroggen @kslee8282 @hayarobi @rabbitprincess