Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small refactoring about names, staking, votings #280

Merged
merged 3 commits into from
Oct 6, 2023
Merged

small refactoring about names, staking, votings #280

merged 3 commits into from
Oct 6, 2023

Conversation

rabbitprincess
Copy link
Member

remove system.InitGovernance ( it is not used )
tidy codes about make event args

@rabbitprincess rabbitprincess requested a review from kroggen October 5, 2023 08:00
kroggen
kroggen approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@kroggen kroggen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, good.

But can this be merged now into that other branch/PR? Is not a sync test running with that branch included?

@rabbitprincess rabbitprincess merged commit a282031 into topic/system-params Oct 6, 2023
@rabbitprincess
Copy link
Member Author

rabbitprincess commented Oct 6, 2023 •
edited
Loading

OK, good.

But can this be merged now into that other branch/PR? Is not a sync test running with that branch included?

sync test start today after merge these branch. ( sync test about v2.4.8 finished today )

@rabbitprincess rabbitprincess deleted the topic/refactor-name branch October 7, 2023 02:57
@rabbitprincess rabbitprincess restored the topic/refactor-name branch October 7, 2023 02:57
@rabbitprincess rabbitprincess deleted the topic/refactor-name branch October 7, 2023 02:57
@rabbitprincess rabbitprincess restored the topic/refactor-name branch October 11, 2023 06:40
@rabbitprincess rabbitprincess deleted the topic/refactor-name branch October 11, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroggen kroggen kroggen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rabbitprincess @kroggen