Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in comments across multiple files #374

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

Pricstas
Copy link

This PR corrects several minor typos in comments across various files, improving the clarity and professionalism of the code documentation.


Files Updated

  1. config/types.go

    • Corrected "joining to a existing cluster" to "joining to an existing cluster."
  2. consensus/chain/block.go

    • Fixed "a error" to "an error."
  3. p2p/p2pcommon/others.go

    • Updated "an another actor module" to "another actor module."
  4. pkg/component/messages.go

    • Changed "an current number of message" to "a current number of message."
  5. types/blockchain.go

    • Corrected "an another actor module" to "another actor module."
  6. types/vote.go

    • Fixed "a unstaking tranaction" to "an unstaking tranaction."
    • Changed "a unprefixed name" to "an unprefixed name."

types/vote.go Outdated Show resolved Hide resolved
@Pricstas
Copy link
Author

Pricstas commented Jan 7, 2025

Hi @kroggen

Just a friendly reminder about pull request #374, which has been approved but hasn't been merged yet.
It fixes several typographical errors in comments across various files.

Thank you!

@kroggen
Copy link
Member

kroggen commented Jan 7, 2025

As you can see, we had to force push the develop branch and this PR now contains old commits that should not be merged

I suspect that these steps should fix your PR:

git remote add upstream https://github.com/aergoio/aergo
git fetch upstream
git checkout develop
git reset --hard upstream/develop
git checkout fix/typos
git rebase --onto develop 9fba61d~1 fix/typos
git push --force

@Pricstas
Copy link
Author

Pricstas commented Jan 8, 2025

Hi @kroggen ,

I have successfully followed the steps you provided to rebase my branch onto the latest develop branch and resolved the conflicts

types/vote.go Outdated Show resolved Hide resolved
types/blockchain.go Outdated Show resolved Hide resolved
pkg/component/messages.go Outdated Show resolved Hide resolved
pkg/component/messages.go Outdated Show resolved Hide resolved
consensus/chain/block.go Outdated Show resolved Hide resolved
p2p/p2pcommon/others.go Outdated Show resolved Hide resolved
@kroggen
Copy link
Member

kroggen commented Jan 8, 2025

Cool, the commits are correct now.
I made a last review on the changes

@Pricstas
Copy link
Author

Hi @kroggen
I have made the requested corrections to fix several typographical errors in the comments across various files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants