Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Remove publication linger timeout validation that expected the value to be greater than or equal to the driver-level timeout, because the validation was not working and linger=0 was allowed and is used in tests and also in the Cluster. #1207

Merged
merged 1 commit into from
Aug 4, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions aeron-driver/src/main/java/io/aeron/driver/Configuration.java
Original file line number Diff line number Diff line change
@@ -1735,21 +1735,6 @@ public static void validateMtuLength(final int mtuLength)
}
}

/**
* Validate the publication linger timeout is an appropriate value.
*
* @param timeoutNs to be validated.
* @param driverLingerTimeoutNs set for the driver operation.
* @throws ConfigurationException if the values are not valid.
*/
public static void validatePublicationLingerTimeoutNs(final long timeoutNs, final long driverLingerTimeoutNs)
{
if (timeoutNs < driverLingerTimeoutNs)
{
throw new ConfigurationException("linger=" + driverLingerTimeoutNs + " < timeoutNs =" + timeoutNs);
}
}

/**
* Get the {@link TerminationValidator} implementations which can be used for validating a termination request
* sent to the driver to ensure the client has the right to terminate a driver.
Original file line number Diff line number Diff line change
@@ -255,7 +255,6 @@ private void getLingerTimeoutNs(final ChannelUri channelUri)
if (null != lingerParam)
{
lingerTimeoutNs = SystemUtil.parseDuration(LINGER_PARAM_NAME, lingerParam);
Configuration.validatePublicationLingerTimeoutNs(lingerTimeoutNs, lingerTimeoutNs);
}
}