Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just use num::Num as trait for T in kd_tree #20

Closed
wucke13 opened this issue Nov 25, 2021 · 0 comments
Closed

Just use num::Num as trait for T in kd_tree #20

wucke13 opened this issue Nov 25, 2021 · 0 comments
Assignees
@sevenautumns

Comments

@wucke13
Copy link
Member

wucke13 commented Nov 25, 2021

The Tree struct of KdTree has a lengthy list of trait bounds for T. Among them already is num::traits::Zero:

openTAWS/kd_tree/src/lib.rs

Line 27 in e9d1818

+ Zero

Why not use num::Num as trait bound and be done with it?
sevenautumns added a commit that referenced this issue Nov 26, 2021
@sevenautumns
solves #20
478ed7d
wucke13 pushed a commit that referenced this issue Nov 26, 2021
@sevenautumns
solves #20
706f6c6
wucke13 pushed a commit that referenced this issue Nov 26, 2021
@sevenautumns @wucke13
solve #20: clean up trait usage in kd_tree
34d2567 
+ replace `core::ops::*` by `num::traits::Num`
+ remove unnecessary trait bounds like `Sized`
+ break long comment lines
wucke13 pushed a commit that referenced this issue Nov 26, 2021
Revert "solves #20"
3f3e052 
This reverts commit 706f6c6.
wucke13 pushed a commit that referenced this issue Nov 26, 2021
@sevenautumns
solve #20: clean up trait usage in kd_tree
672f67f 
+ replace `core::ops::*` by `num::traits::Num`
+ remove unnecessary trait bounds like `Sized`
+ break long comment lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sevenautumns sevenautumns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wucke13 @sevenautumns