Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/filter expressions #284

Merged
merged 6 commits into from
Sep 14, 2021
Merged

Feature/filter expressions #284

merged 6 commits into from
Sep 14, 2021

Conversation

roimenashe
Copy link
Member

Filter Expressions support instead of deprecated PredExp.
https://docs.aerospike.com/docs/guide/expressions/#filter-expressions

@roimenashe roimenashe requested review from Aloren and reugn September 8, 2021 17:48
@roimenashe roimenashe self-assigned this Sep 8, 2021
@roimenashe roimenashe linked an issue Sep 8, 2021 that may be closed by this pull request
@Aloren
Copy link

Aloren commented Sep 13, 2021

We will discuss this shortly internally. Thank you.

@Aloren
Copy link

Aloren commented Sep 13, 2021

@roimenashe I've checked documentation on https://docs.aerospike.com/docs/guide/predicate.html and I haven't found which server+client versions support both predexps and new expressions. This is required for the migration from the old feature to the new one. Can you please point where I can find this information in the documentation. Thank you.

@Aloren
Copy link

Aloren commented Sep 13, 2021

@roimenashe Could you please also check how new feature will behave on older version of server that does not support it?

@roimenashe
Copy link
Member Author

roimenashe commented Sep 13, 2021

@Aloren
Aerospike server version 5.2 (and above) and Aerospike Java Client 5.0.1 (and above) supports both PredExp and FilterExpressions till November 2021 (PredExp will be removed permanently in less than 2 month from now).
I got it from the release notes:
https://download.aerospike.com/download/server/notes.html#5.2.0.2
https://download.aerospike.com/download/client/java/notes.html#5.0.1

Tried to run Spring Data Aerospike on this branch (3.1.0 including the filter-expressions support) using couple of old Aerospike servers (below 5.2):
4.5.0.19: Got exception loading Spring - I guess that version is too old.
5.1.0.25: some Tests fails with errors:
com.aerospike.client.AerospikeException: Error 4,1,0,30000,0,5,BB9040011AC4202 127.0.0.1 55681: Parameter error
and some fails with difference between actual and expected.

I also sent you an email about Filter Expressions and PredExp - and why we believe we should not support both - and of course mention it is a breaking change and as of Spring Data Aerospike 3.2.0 and above we do not support servers with version below 5.2.

@Aloren
Copy link

Aloren commented Sep 13, 2021

Aerospike server version 5.2 (and above) and Aerospike Java Client 5.0.1 (and above) supports both PredExp and FilterExpressions till November 2021

I'm curious about this date. This is just for support or will this feature stop working on production? :)

@roimenashe
Copy link
Member Author

@Aloren Im not sure but according to the warning here https://docs.aerospike.com/docs/guide/predicate.html
I believe it says that server/client version releases after November 2021 - will not contain PredExp. It makes sense cause its marked as deprecated for more than a year, I'll try to verify that with other teams.

@roimenashe
Copy link
Member Author

@Aloren Code will be removed from both server and clients in November 2021.

@roimenashe roimenashe requested a review from Aloren September 14, 2021 10:13
@Aloren
Copy link

Aloren commented Sep 14, 2021

Looks good. Please dont forget to increment major version. Also it would be nice to state in the compatibility matrix the version of the Aerospike server as well. Thank you!

@roimenashe roimenashe merged commit 3984327 into master Sep 14, 2021
@roimenashe roimenashe deleted the feature/filter-expressions branch September 14, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support aerospike expressions
3 participants