-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/filter expressions #284
Conversation
We will discuss this shortly internally. Thank you. |
@roimenashe I've checked documentation on https://docs.aerospike.com/docs/guide/predicate.html and I haven't found which server+client versions support both predexps and new expressions. This is required for the migration from the old feature to the new one. Can you please point where I can find this information in the documentation. Thank you. |
@roimenashe Could you please also check how new feature will behave on older version of server that does not support it? |
@Aloren Tried to run Spring Data Aerospike on this branch (3.1.0 including the filter-expressions support) using couple of old Aerospike servers (below 5.2): I also sent you an email about Filter Expressions and PredExp - and why we believe we should not support both - and of course mention it is a breaking change and as of Spring Data Aerospike 3.2.0 and above we do not support servers with version below 5.2. |
I'm curious about this date. This is just for support or will this feature stop working on production? :) |
@Aloren Im not sure but according to the warning here https://docs.aerospike.com/docs/guide/predicate.html |
@Aloren Code will be removed from both server and clients in November 2021. |
src/main/java/org/springframework/data/aerospike/query/FilterExpressions.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/aerospike/query/QueryEngine.java
Outdated
Show resolved
Hide resolved
Looks good. Please dont forget to increment major version. Also it would be nice to state in the compatibility matrix the version of the Aerospike server as well. Thank you! |
Filter Expressions support instead of deprecated PredExp.
https://docs.aerospike.com/docs/guide/expressions/#filter-expressions