fix circular dependency for AerospikePersistenceEntityIndexCreator

[Aloren]

No description provided.

[Aloren]

relates to:
aerospike-community/spring-data-aerospike-starters#108
spring-projects/spring-data-commons#2587

To resolve the issue with circular dependency, I've done the following:

• IndexCreator now does not use aerospikeMappingContext in onApplicationEvent. Because aerospikeMappingContext is the one, that produces these events. It means that when indexCreator receives MappingContextEvent from aerospikeMappingContext --- aerospikeMappingContext field in indexCreator is currently being initialised :)
• instead IndexCreator saves events and processes them only in start method, when aerospikeMappingContext is finally initialised.
• remove createIndexesOnStartup from aerospikeMappingContext as it can not be used in IndexCreator, and moved it to AerospikeDataSettings
• i've created MappingContextEvent source makes spring-data modules create circular dependencies spring-projects/spring-data-commons#2587 ticket to address that currently linking indexCreator to specific mappingContext is quite cumbersome and requires dirty workarounds (providing linked mappingContext via ObjectProvider and using it only after initialisation is complete).

[Aloren]

Let's merge?
And also can you please release. I think it should be 3.4.0. WDYT?

[roimenashe]

@Aloren If we bump spring then it's definitely 3.4.0.
1 more thing before we merge and release 3.4.0, check the latest email, I think that we need to bump spring-data-parent, spring-data-commons and spring-data-keyvalue as well (from 2.5.6 to 2.6.3 [latest]), am I missing something?

[Aloren]

Thanks. Will check now which spring-data-parent is expected to come with SB 2.6

[Aloren]

All 3 PRs for spring-data-* updates need to be merged as well.

[Aloren]

let's merge them separately:
#350
#351
#352

[Aloren]

since you are already upgrading spring-cloud-starter-bootstrap and spring-boot-starter-test?

I've upgraded them, because they were causing an issue that is fixed in this PR.