Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move testcontainers bootstrap properties to test resources #377

Merged
merged 1 commit into from
May 9, 2022

Conversation

jnopnop
Copy link

@jnopnop jnopnop commented Apr 28, 2022

  • fix docker image version, since 5.5.0.3 and newer fail checksum validation

@roimenashe
Copy link
Member

@jnopnop
Thanks for creating this PR.
Can you please provide more information about this issue? fails where? under which circumstances?
5.5.0.3 is being used more than a year and tests completes successfully.

@roimenashe roimenashe self-requested a review May 1, 2022 10:24
@jnopnop
Copy link
Author

jnopnop commented May 2, 2022

@roimenashe, this is what I'm getting when trying to pull 5.5.0.3:

% docker pull aerospike/aerospike-server:5.5.0.3  
5.5.0.3: Pulling from aerospike/aerospike-server
cae7303ade7f: Verifying Checksum 
aca507f16e13: Verifying Checksum 
829a4d716723: Download complete 
daeb228a2a38: Download complete 
filesystem layer verification failed for digest sha256:aca507f...

Unfortunately newer versions fail checksum validation as well. However 5.5.0.2 works like a charm.

Just to be clear, the main goal of this PR is to move bootstrap.properties to the test resources, where they belong.
Aerospike container version is the second [optional] question. I can of course leave the current one, but it just doesn't work.
WDYT?

@reugn
Copy link
Member

reugn commented May 2, 2022

@jnopnop the image is available, and you should be able to pull it. Try to restart your docker daemon and remove Aerospike images before.

@Aloren
Copy link

Aloren commented May 2, 2022

The main issue is spring-data-aerospike providing it's test properties in production resources, thus overriding user properties.
@jnopnop please revert change with the version and leave only moving of the bootstrap.properties file to the test resources folder.

@jnopnop jnopnop force-pushed the feature/move-bootstrap-props branch from 97699a5 to e00778c Compare May 3, 2022 07:56
@jnopnop
Copy link
Author

jnopnop commented May 3, 2022

@roimenashe
Copy link
Member

@jnopnop
You'r PR is approved, you can merge it (and delete branch).

@jnopnop
Copy link
Author

jnopnop commented May 9, 2022

@roimenashe, I don't have permissions to merge, could you please do it?
Thanks!

@roimenashe roimenashe merged commit 5f94695 into aerospike:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants