FMWK-123 Handle new behavior of create / drop secondary index #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eKeyValueAdapter as unused
…ls.IndexExists(), partial rollback in IndexUtils to support Server versions prior to 6.1.0.1
reugn
reviewed
Feb 19, 2023
src/test/java/org/springframework/data/aerospike/IndexUtils.java
Outdated
Show resolved
Hide resolved
| public static boolean indexExists(IAerospikeClient client, String namespace, String indexName) { | ||
| Node node = getNode(client); | ||
| String response = Info.request(node, "sindex/" + namespace + '/' + indexName); | ||
| return !response.startsWith("FAIL:201"); | ||
| } | ||
|
|
||
| public static String getServerVersion(IAerospikeClient client) { | ||
| String versionString = Info.request(null, client.getCluster().getRandomNode(), "version"); |
| /** | ||
| * @deprecated since Aerospike Server ver. 6.1.0.1. Use | ||
| * {@link org.springframework.data.aerospike.core.AerospikeTemplate#indexExists(String)} | ||
| */ | ||
| public static boolean indexExists(IAerospikeClient client, String namespace, String indexName) { | ||
| Node node = getNode(client); |
There was a problem hiding this comment.
Use client.getCluster().getRandomNode() and remove the getNode method.
src/main/java/org/springframework/data/aerospike/core/AerospikeTemplate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/aerospike/core/AerospikeTemplate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/aerospike/core/AerospikeTemplate.java
Show resolved
Hide resolved
src/main/java/org/springframework/data/aerospike/IndexAlreadyExistsException.java
Show resolved
Hide resolved
| return false; | ||
| } else { | ||
| String regex = "^FAIL:(-?\\d+).*$"; | ||
| Matcher matcher = Pattern.compile(regex).matcher(response); |
There was a problem hiding this comment.
Compile the pattern once as a static.
…eTemplate.java Co-authored-by: Eugene R. <[email protected]>
roimenashe
reviewed
Feb 20, 2023
| try { | ||
| Node[] nodes = reactorClient.getAerospikeClient().getNodes(); | ||
| for (Node node : nodes) { | ||
| String response = Info.request(node, "sindex-exists:ns=" + namespace + ";indexname=" + indexName); |
There was a problem hiding this comment.
I don't see sindex-exists in as-info commands reference: https://docs.aerospike.com/reference/info
Also, we need to verify whether this info call is a node level or a cluster level (your code assumes its a node level info call but I remember that with indexes api it's enough to send as info call to a single node).
There was a problem hiding this comment.
It was done according to Brian's letter (attached as a comment to FMWK-123)
roimenashe
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.