Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMWK-155 Todos cleanup #566

Merged
merged 7 commits into from
May 11, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ public class AerospikeNamespaceHandler extends NamespaceHandlerSupport {
@Override
public void init() {

// TODO: add declarations and namespaces for other top-level configuration elements
registerBeanDefinitionParser("client", new AerospikeClientBeanDefinitionParser());
registerBeanDefinitionParser("clientPolicy", new ClientPolicyBeanDefinitionParser());
registerBeanDefinitionParser("readPolicy", new ReadPolicyBeanDefinitionParser());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,5 @@ protected Class<?> getBeanClass(Element element) {
@Override
protected void doParse(Element element, BeanDefinitionBuilder builder) {
ParsingUtils.setPropertyValue(builder, element, "max-concurrent-threads");
// TODO: set all properties of the XML element on the builder
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,5 @@ protected Class<?> getBeanClass(Element element) {
protected void doParse(Element element, BeanDefinitionBuilder builder) {
ParsingUtils.setPropertyValue(builder, element, "maxThreads");
ParsingUtils.setPropertyValue(builder, element, "timeOut");
// TODO: set all properties of the XML element on the builder
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,5 @@ protected Class<?> getBeanClass(Element element) {
@Override
protected void doParse(Element element, BeanDefinitionBuilder builder) {
ParsingUtils.setPropertyValue(builder, element, "max-concurrent-threads");
// TODO: set all properties of the XML element on the builder
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,5 @@ protected Class<?> getBeanClass(Element element) {
@Override
protected void doParse(Element element, BeanDefinitionBuilder builder) {
ParsingUtils.setPropertyValue(builder, element, "max-concurrent-threads");
// TODO: set all properties of the XML element on the builder
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,5 @@ protected Class<?> getBeanClass(Element element) {
@Override
protected void doParse(Element element, BeanDefinitionBuilder builder) {
ParsingUtils.setPropertyValue(builder, element, "max-concurrent-threads");
// TODO: set all properties of the XML element on the builder
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,5 @@ protected Class<?> getBeanClass(Element element) {
@Override
protected void doParse(Element element, BeanDefinitionBuilder builder) {
ParsingUtils.setPropertyValue(builder, element, "max-concurrent-threads");
// TODO: set all properties of the XML element on the builder
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,15 @@ private ApplicationContext getApplicationContext() {

return applicationContext;
}

protected static Object getBinValue(String name, Collection<Bin> bins) {
if (bins == null || bins.isEmpty())
return null;

return bins.stream()
.filter(bin -> bin.name.equals(name))
.map(bin -> bin.value.getObject())
.findFirst().orElse(null);
}

reugn marked this conversation as resolved.
Show resolved Hide resolved
}
Loading