FMWK-179 Find by map/list containing: similar logic, multiple arguments #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r multiple key&value pairs in findByMapContaining
…ListContaining, add support for String and null arguments for LIST_VAL_BETWEEN
reugn
reviewed
May 23, 2023
| params.add(0, value1); // value1 stores the first parameter | ||
| if (op == MAP_VAL_CONTAINING_BY_KEY || op == MAP_VAL_EQ_BY_KEY) { | ||
| if (params.size() > 2) { | ||
| if ((params.size() & 1) != 0) { |
| return aerospikeCriteriaAndConcatenated(params, qb, part, fieldName, op, dotPath, true); | ||
| } else if (params.size() == 2) { | ||
| setQbValuesForMapByKey(qb, params.get(0), params.get(1)); | ||
| } |
There was a problem hiding this comment.
what happens if params.size() < 2?
There was a problem hiding this comment.
Then the default flow continues with just the op set before and the logic in these conditions is not applied.
| List<Object> params = new ArrayList<>(); | ||
| parameters.forEachRemaining(params::add); | ||
|
|
||
| if (params.size() >= 1 |
| if (IndexUtils.isFindByPojoSupported(client)) { | ||
| List<String> listToCompareWith = List.of("str1", "str2"); | ||
| assertThat(dave.getStrings()).isEqualTo(listToCompareWith); | ||
| // if (IndexUtils.isFindByPojoSupported(client)) { |
…n/lessThan instead of null in findBetween
reugn
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.