FMWK-224 Add support for id projection query via Repository #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reugn
reviewed
Aug 11, 2023
| // No projection - target class will be the entity class. | ||
| return queryMethod.getEntityInformation().getJavaType(); | ||
| } | ||
|
|
||
| public Query createQuery(ParametersParameterAccessor accessor, PartTree tree) { | ||
| Constructor<? extends AbstractQueryCreator<?, ?>> constructor = ClassUtils | ||
| .getConstructorIfAvailable(queryCreator, PartTree.class, ParameterAccessor.class); |
There was a problem hiding this comment.
Add validation
Assert.notNull(constructor, "constructor must not be null");There was a problem hiding this comment.
The same assertion is the first line inside BeanUtils.instantiateClass()
There was a problem hiding this comment.
Lines 89-93 use
if (query.getCriteria() instanceof SpelExpression spelExpression) {
EvaluationContext context = this.evaluationContextProvider.getEvaluationContext(queryMethod.getParameters(),
parameters);
spelExpression.setEvaluationContext(context);
}| @@ -46,6 +50,8 @@ protected BaseAerospikePartTreeQuery(QueryMethod queryMethod, | |||
| this.queryMethod = queryMethod; | |||
| this.evaluationContextProvider = evalContextProvider; | |||
| this.queryCreator = queryCreator; | |||
| this.sourceClass = queryMethod.getEntityInformation().getJavaType(); | |||
|
|
|||
| public Query createQuery(ParametersParameterAccessor accessor, PartTree tree) { | ||
| Constructor<? extends AbstractQueryCreator<?, ?>> constructor = ClassUtils | ||
| .getConstructorIfAvailable(queryCreator, PartTree.class, ParameterAccessor.class); | ||
| return (Query) BeanUtils.instantiateClass(constructor, tree, accessor).createQuery(); | ||
| } | ||
|
|
||
| protected static boolean isIdProjectionQuery(Class<?> targetClass, Object[] params, AerospikeCriteria criteria) { | ||
| return targetClass != null && params.length > 0 && Objects.equals(criteria.get(FIELD), "id"); |
| @@ -52,11 +53,27 @@ public Object execute(Object[] parameters) { | |||
|
|
|||
| Class<?> targetClass = getTargetClass(accessor); | |||
|
|
|||
| if (isIdProjectionQuery(targetClass, parameters, (AerospikeCriteria) query.getCriteria())) { | |||
There was a problem hiding this comment.
- Add a comment explaining this block
- Is
query.getCriteria()always an AerospikeCriteria?
| // Dynamic projection | ||
| if (accessor.getParameters().hasDynamicProjection()) { | ||
| return accessor.findDynamicProjection(); | ||
| if (isIdProjectionQuery(targetClass, parameters, (AerospikeCriteria) query.getCriteria())) { |
There was a problem hiding this comment.
Add a comment explaining this block
reugn
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.