FMWK-252 Refactor query creator #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reugn
reviewed
Oct 30, 2023
| private Qualifier processId(Object value1) { | ||
| Qualifier qualifier; | ||
| if (value1 instanceof Collection<?>) { | ||
| qualifier = forIds(((Collection<?>) value1).toArray(String[]::new)); |
There was a problem hiding this comment.
Unsafe transition from a collection of Object to an array of String.
|
|
||
| private Qualifier processCollection(Part part, Object value1, Object value2, Iterator<?> parameters, | ||
| FilterOperation op, String fieldName) { | ||
| String dotPath = null; |
There was a problem hiding this comment.
dotPath is always null. Consider passing an explicit null as an argument.
| qualifiers[j++] = setQualifierBuilderValues(qb, fieldName, op, part, params.get(i), | ||
| null, null, dotPath).build(); | ||
| qualifiers[j++] = setQualifier(qb, fieldName, op, part, params.get(i), | ||
| null, null, dotPath); | ||
| } | ||
|
|
||
| return new AerospikeCriteria(Qualifier.and(qualifiers)); |
There was a problem hiding this comment.
Why wrapping with AerospikeCriteria?
| Qualifier[] qualifiers; | ||
| if (containingMapKeyValuePairs) { | ||
| qualifiers = new Qualifier[params.size() / 2]; // keys/values qty must be even | ||
| for (int i = 0, j = 0; i < params.size(); i += 2) { | ||
| setQbValuesForMapByKey(qb, params.get(i), params.get(i + 1)); | ||
| qualifiers[j++] = setQualifierBuilderValues(qb, fieldName, op, part, params.get(i), | ||
| null, null, dotPath).build(); | ||
| qualifiers[j++] = setQualifier(qb, fieldName, op, part, params.get(i), |
There was a problem hiding this comment.
Increment j in the increment section of the for statement.
| return setQualifier(qb, fieldName, op, part, value1, value2, null, dotPath); | ||
| } | ||
|
|
||
| private Qualifier processMapMultipleParams(Part part, Object value1, Object value2, List<Object> params, |
There was a problem hiding this comment.
Check if this method can be refactored/simplified further.
|
Nothing to add other than @reugn's comments |
reugn
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.