Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FMWK-301 Support beforeLastUpdate parameter in deleteAll #682

Merged
merged 9 commits into from
Dec 28, 2023
Merged

FMWK-301 Support beforeLastUpdate parameter in deleteAll #682

merged 9 commits into from
Dec 28, 2023

Conversation

agrgr
Copy link

@agrgr agrgr commented Dec 27, 2023

No description provided.

@agrgr agrgr requested review from roimenashe and reugn December 27, 2023 15:09
@agrgr agrgr marked this pull request as ready for review December 27, 2023 15:23
roimenashe
roimenashe approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@roimenashe roimenashe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as we discussed keep only 1 API of deleteAll() with time consideration (either Long or Instant).

@agrgr agrgr merged commit efa5691 into main Dec 28, 2023
9 checks passed
@agrgr agrgr deleted the FMWK-301-truncate-beforeLastUpdate branch December 28, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reugn reugn reugn approved these changes

@roimenashe roimenashe roimenashe approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrgr @roimenashe @reugn