Update various thingies #1278
Merged
Update various thingies #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking change
github-actions
bot
removed
the
breaking change
wolfcomp
reviewed
Jan 18, 2025
| @@ -49,7 +49,7 @@ public void OpenForItemSlot(InventoryType inventory, int slot, uint addonId) { | |||
| } | |||
|
|
|||
| [MemberFunction("E8 ?? ?? ?? ?? E9 ?? ?? ?? ?? 48 8D 0D ?? ?? ?? ?? E8 ?? ?? ?? ?? 4C 89 74 24 ??")] | |||
| public partial long UseItem(uint itemId, uint inventoryType = 9999, uint itemSlot = 0, short a5 = 0); | |||
| public partial long UseItem(uint itemId, uint inventoryType = 9999, uint itemSlot = 0, short a5 = 0); // TODO: use InventoryType.Invalid | |||
There was a problem hiding this comment.
Wouldn't it make more sense to update the inventoryType to the enum type, instead of just updating the default type to use the enum?
Of course only making it as a todo statement since that would be a breaking change if done now
There was a problem hiding this comment.
I didn’t mean to write (uint)InventoryType.Invalid, lol.
Of course the type should be changed too, but I didn’t want to touch it right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought I'd PR before it gets even more.